Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Global-exports to require React and support node modules #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deraen
Copy link

@Deraen Deraen commented Aug 18, 2017

This is similar to reagent-project/reagent#306
https://github.com/reagent-project/reagent/blob/master/CHANGELOG.md#080-alpha1-2017-07-31

I'm opening PR's on other related projects also:

It is possible further changes to ClojureScript will make this change (partially) unnecessary: https://dev.clojure.org/jira/browse/CLJS-2331

There are problems with this change currently,

Running build with boot devcards shows lots of warnings:

WARNING: No such namespace: react, could not locate react.cljs, react.cljc, or JavaScript source providing "react" at line 6 src/devcards/om/devcards/shared_fn_test.cljs

And errors at browser console, caused by code generated by defui:
image

@petterik
Copy link
Contributor

@Deraen the CircleCI build failed because it couldn't find artifact devcards:devcards-0.3.0-SNAPSHOT.
Maybe try rebuilding the build? Or if it actually doesn't exist, update the version?

@Deraen
Copy link
Author

Deraen commented Aug 29, 2017

@petterik It doesn't exist as that depends on devcards update (PR linked), and all the changes are still WIP, and the devcards update depends on om update. It will be fun to release these, when this is ready, due to cyclic dependencies :)

@petterik
Copy link
Contributor

petterik commented Sep 9, 2017

Btw @Deraen, I tried to get om.next to work with react from node_modules and started from your WIP commit in this pull request. I had to some more changes to do with om.dom marcos referring to js/React and js/React.DOM, and maybe something else.

Not everything I did is related to this PR, but here's the diff:
Deraen/om@new-react-require...petterik:petter/new-react-require

@Deraen
Copy link
Author

Deraen commented Sep 9, 2017

@petterik Nice. Perhaps similar macro fixes will help with Sablono and Rum, which I think also had similar problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants