Prevent PassthroughWindow from overriding status bar style #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ky1vstar and apologies for the late response I'm against the use of any private APIs in libraries, even if it is a know issue, I added a workaround in v1.3.0 that gets the top view controller's status bar style before showing a drop, and uses it in the temp window that is used to show drops. |
|
@ky1vstar @omaralbeik just found this thread. I had the same problem a while ago in Popovers. We ultimately went with not creating a new UIWindow and instead just overlaying a view controller as a subview. The private API looks handy though, I'll investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! When presenting
Dropabove view controller that haspreferredStatusBarStyleset to.lightContentthere is a bug. Status bar turns to black whileDropis presented, and turn back to expected color (white) when dismissed. This PR fix this behaviour usingUIWindow's private API override. There are several open radars related to this, but none of them is fixed. This fix is totally safe and we are using it in App Store without any issues for three years now.