Support new font families #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omacranger
requested changes
Dec 25, 2024
| { | ||
| "sharp-duotone-solid": ["star"], | ||
| }, | ||
| [{ family: "fa-sharp-duotone-solid-900.woff2", icon: "star" }] |
There was a problem hiding this comment.
Don't need .woff2 here since the font file should be handled by the helper
Comment on lines
+196
to
+201
| { family: "fa-duotone-regular-400.woff2", icon: "star" }, | ||
| { family: "fa-duotone-light-300.woff2", icon: "star" }, | ||
| { family: "fa-duotone-thin-100.woff2", icon: "star" }, | ||
| { family: "fa-sharp-duotone-regular-400.woff2", icon: "star" }, | ||
| { family: "fa-sharp-duotone-light-300.woff2", icon: "star" }, | ||
| { family: "fa-sharp-duotone-thin-100.woff2", icon: "star" }, |
There was a problem hiding this comment.
Same with .woff2 file extensions here
| itGTE("6.7.0", "pro")( | ||
| "should add requested glyphs for new font styles in duotone-(regular|light|thin) and sharp-duotone-(regular|light|thin)", | ||
| async () => { | ||
| expect.assertions(1); |
There was a problem hiding this comment.
expect.assertions(6);
This will create 6 dynamic assertions so this expect should reflect that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support 8 new font families added since 6.4 (changelog):
sharp-thinduotone-lightduotone-regularduotone-thinsharp-duotone-lightsharp-duotone-regularsharp-duotone-solidsharp-duotone-thinFixes #38