fix: slow crossfade when take 32channels. dispatchTrigger added, so s…

…tore only updates every 5 times the OSC fader is updated.
olzzon · Jun 23, 2019 · f70061d · f70061d
1 parent d01d3ca
commit f70061d
Showing 1 changed file with 33 additions and 17 deletions.
diff --git a/src/utils/MixerConnection.ts b/src/utils/MixerConnection.ts
@@ -94,19 +94,25 @@ export class MixerGenericConnection {
         if (this.mixerProtocol.mode === "master") {
             targetVal = parseFloat(this.store.channels[0].channel[channelIndex].faderLevel);
         }
-        const step = (targetVal-outputLevel)/(fadeTime/FADE_INOUT_SPEED);
-
+        const step: number = (targetVal-outputLevel)/(fadeTime/FADE_INOUT_SPEED);
+        const dispatchResolution: number = 5*step;
+        let dispatchTrigger: number = 0;
 
         if (targetVal<outputLevel) {
             this.timer[channelIndex] = setInterval(() => {
                 outputLevel += step;
                 this.mixerConnection.updateFadeIOLevel(channelIndex, outputLevel);
 
-                window.storeRedux.dispatch({
-                    type:'SET_OUTPUT_LEVEL',
-                    channel: channelIndex,
-                    level: outputLevel
-                });
+                dispatchTrigger += step;
+
+                if (dispatchTrigger > dispatchResolution) {
+                    window.storeRedux.dispatch({
+                        type:'SET_OUTPUT_LEVEL',
+                        channel: channelIndex,
+                        level: outputLevel
+                    });
+                    dispatchTrigger = 0;
+                }
 
                 if ( outputLevel <= targetVal){
                     outputLevel = targetVal;
@@ -131,11 +137,15 @@ export class MixerGenericConnection {
                 outputLevel += step;
                 this.mixerConnection.updateFadeIOLevel(channelIndex, outputLevel);
 
-                window.storeRedux.dispatch({
-                    type:'SET_OUTPUT_LEVEL',
-                    channel: channelIndex,
-                    level: outputLevel
-                });
+                if (dispatchTrigger > dispatchResolution) {
+                    window.storeRedux.dispatch({
+                        type:'SET_OUTPUT_LEVEL',
+                        channel: channelIndex,
+                        level: outputLevel
+                    });
+                    dispatchTrigger = 0;
+                }
+
 
                 if ( outputLevel >= targetVal ) {
                     outputLevel = targetVal;
@@ -162,17 +172,23 @@ export class MixerGenericConnection {
         let outputLevel = this.store.channels[0].channel[channelIndex].outputLevel;
         const min = this.mixerProtocol.fader.min;
         const step = (outputLevel-min)/(fadeTime/FADE_INOUT_SPEED);
+        const dispatchResolution: number = 5*step;
+        let dispatchTrigger: number = 0;
 
         this.timer[channelIndex] = setInterval(() => {
 
             outputLevel -= step;
             this.mixerConnection.updateFadeIOLevel(channelIndex, outputLevel);
 
-            window.storeRedux.dispatch({
-                type:'SET_OUTPUT_LEVEL',
-                channel: channelIndex,
-                level: outputLevel
-            });
+            if (dispatchTrigger > dispatchResolution) {
+                window.storeRedux.dispatch({
+                    type:'SET_OUTPUT_LEVEL',
+                    channel: channelIndex,
+                    level: outputLevel
+                });
+                dispatchTrigger = 0;
+            }
+
 
             if ( outputLevel <= min ){
                 outputLevel=min;