fix: migration should write settings in sync mode to prevent async lo…

…ading of old settings
olzzon · Mar 25, 2021 · 00e004f · 00e004f
1 parent 39c9f05
commit 00e004f
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/server/utils/migrations.ts b/server/utils/migrations.ts
@@ -67,6 +67,17 @@ const migrate45to46 = (currentSettings: ISettings): ISettings => {
         )
     })
     currentSettings.sisyfosVersion = version
-    saveSettings(currentSettings)
+    delete currentSettings.customPages
+    fs.writeFileSync(
+        path.resolve('storage', 'settings.json'),
+        JSON.stringify(currentSettings),
+        'utf8',
+        (error: any) => {
+            logger.error(
+                'Migration failed - error writing settings.json file: ',
+                error
+            )
+        }
+    )
     return currentSettings
 }