Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countdown Component #1632

Closed
Dexilez opened this issue Sep 19, 2020 · 8 comments
Closed

Countdown Component #1632

Dexilez opened this issue Sep 19, 2020 · 8 comments
Milestone

Comments

@Dexilez
Copy link

Dexilez commented Sep 19, 2020

Hello,

I was testing countdown component and i found out that some values are printing wrong.

Example:

Date is 9/19/2020 6:57pm right now.
My code is:
<span data-role="countdown" data-date="11/19/2020 00:00:00" id="countdownItems" class="countdownItems">
Output is:
resim
It should be
60 Days
05 Hours
01 Mins
06 Secs

If i change my code to:
<span data-role="countdown" data-date="11/20/2020 00:00:00" id="countdownItems" class="countdownItems">
Output is:
resim

and this is correct.

I want to learn if i do anything wrong in my code but i don't think so. Is that a bug? I am looking forward for your answer.

Thanks.
Regards.

@olton
Copy link
Owner

olton commented Sep 19, 2020

use date format mm/dd/yyyy

@Dexilez
Copy link
Author

Dexilez commented Sep 19, 2020

use date format mm/dd/yyyy

I am already using it like that or did i get you wrong? @olton
data-date="11/20/2020"
isn't it mm/dd/yyyy?

@Dexilez
Copy link
Author

Dexilez commented Sep 19, 2020

one more example

This is correct:
resim

This is wrong:
resim
it should be 10 hours. but 0 and 1 changes places.

@olton olton added the bug label Sep 19, 2020
@olton
Copy link
Owner

olton commented Sep 19, 2020

Thank you. It's strange. This bug appears for any month on the 19th :0

@Dexilez
Copy link
Author

Dexilez commented Sep 19, 2020

Thank you. It's strange. This bug appears for any month on the 19th :0

not 19th of the month actually.
Something strange is happening when 0 comes near any number. whether it is days, hours, minutes or seconds.

10
20
30
40
50
...

These are appears as:

01
02
03
04
05
... 

and so on

@olton
Copy link
Owner

olton commented Sep 19, 2020

Thanks, bug confirmed in a draw function.

olton added a commit that referenced this issue Sep 19, 2020
@olton
Copy link
Owner

olton commented Sep 19, 2020

Fixed in 4.4.0, Please check it...

@olton olton added this to the 4.4.0 milestone Sep 19, 2020
@olton olton added the Fixed label Sep 19, 2020
@Dexilez
Copy link
Author

Dexilez commented Sep 28, 2020

Done! Thanks @olton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants