Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchors should work with "data-hotkey" attribute #1420

Closed
docoliver opened this issue Sep 30, 2019 · 1 comment
Closed

Anchors should work with "data-hotkey" attribute #1420

docoliver opened this issue Sep 30, 2019 · 1 comment
Labels
enhancement Fixed
Milestone
4.3.2

Comments

@docoliver
Copy link

As of now, an onclick attribute is required for all elements with the attribute data-hotkey in order for the hotkey to actually work.

You can't set hotkeys for links unless you add onclick="window.location.href='website.com'" as an attribute. I think this is tedious and the data-hotkey should look for the href attribute on an anchor, and once the specified hotkey is pressed, the redirect is triggered.
@olton olton added this to the 4.3.2 milestone Oct 5, 2019
olton added a commit that referenced this issue Oct 5, 2019
@olton
HotKey: extended anchor work with data-hotkey and attr href, issue …
f93307c 
…#1420
@olton olton added the Fixed label Oct 5, 2019
olton added a commit that referenced this issue Oct 5, 2019
@olton
HotKey: extended anchor work with data-hotkey and attr href, issue …
0b5ff0e 
…#1420
@olton
Copy link
Owner

olton commented Oct 5, 2019

Hi, thx for this report. I added this feature in 4.3.2. You can test it from GitHub 4.3.2 branch or get from CDN for develop branch.

@olton olton closed this as completed Oct 20, 2019
olton added a commit that referenced this issue Oct 28, 2023
@olton
HotKey: extended anchor work with data-hotkey and attr href, issue …
dfbdeb0 
…#1420
olton added a commit that referenced this issue Oct 28, 2023
@olton
HotKey: extended anchor work with data-hotkey and attr href, issue …
3aa1619 
…#1420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Fixed
Projects
None yet
Milestone
4.3.2
Development

No branches or pull requests
2 participants
@olton @docoliver