-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spyglass.py #324
base: main
Are you sure you want to change the base?
Update spyglass.py #324
Conversation
The run_main runs the spyglass tool. There are two targets in the make file. args = ["-i"] option is required to ignore the error code from the first design read target and run the lint target.
Hi @jgbhatia. Thank you for this patch. I'm not completely sure how the spyglass backend works but if I understand correctly it tries to run multiple goals and if any of them fails, it will not run the other ones. I wonder if everyone wants to have it this way or if we should add an option so that users can select which behavior they want. Perhaps @imphil can give some input here? Your fix looks fine, but I think we can make it simpler. spyglass doesn't handle plusargs (AFAIU) so we only need to set the |
Hi @olofk, thanks for your response. When I configured fusesoc for my design setup, I found that the setup was created for spyglass but the spyglass did not run. It was because the run_main routine was not present. After adding the run_main routine, I hit another issue. The makefile has two targets, run-goal-design_read & run-goal-lint_lint_rtl. It always used to run the design_read goal and exit with an error. Hence I added -i option so that make can ignore the error and execute the next goal. |
I see. I have no idea why |
I have pushed the changes as mentioned by @jgbhatia |
Change the name of the output file list.
Only search path and the file list.
The run_main runs the spyglass tool. There are two targets in the make file. args = ["-i"] option is required to ignore the error code from the first design read target and run the lint target.