Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Stats API in 7.15 broken #1535

Open
olivere opened this issue Sep 27, 2021 · 1 comment
Open

Node Stats API in 7.15 broken #1535

olivere opened this issue Sep 27, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@olivere
Copy link
Owner

olivere commented Sep 27, 2021

Seems like the Node Stats API in 7.15.0 is broken due to this change (reported here). See also elastic/elasticsearch#78311.

How to reproduce:

  1. Use 7.15.0
  2. Run the Node Stats API with level=shards: $ curl -H 'Content-Type: application/json' -XGET 'http://localhost:9200/_nodes/stats?level=shards&human=true&pretty=true'

Expected outcome:

All JSON keys on the same level are different.

Actual response:

You'll get a duplicate JSON key for shards:

      ...
      "indices" : {
        "docs" : {
          "count" : 48,
          "deleted" : 0
        },
        "shards" : {                   // <--
          "total_count" : 2
        },
        ...
        "shards" : {                   // <--
          ".tasks" : [
            {
              "0" : {
                "routing" : {
                  "state" : "STARTED",
                  "primary" : true,
                  "node" : "f8Z10TwPSKqTNsnnJiFRtg",
                  "relocating_node" : null
                },
                "docs" : {
                  "count" : 5,
                  "deleted" : 0
                },
          "memory_size_in_bytes" : 0,
          "evictions" : 0
        },
        ...
@olivere olivere added the bug label Sep 27, 2021
@olivere olivere added this to the 7.0.30 milestone Sep 27, 2021
olivere added a commit that referenced this issue Oct 6, 2021
This commit brings the Nodes Stats API to the latest version.

Notice that 7.15.0 has a
elastic/elasticsearch#78311 that is likely
being fixed by elastic/elasticsearch#78531, so
we're skipping the given test for that specific release.

Once 7.15.1 is released, the bug might reappear unless the PR is being
merged into that version.

See #1535
olivere added a commit that referenced this issue Oct 14, 2021
This commit adds a preliminary fix for
elastic/elasticsearch#78311 that is, however,
not yet released as of 7.15.1.

See #1535
@olivere olivere modified the milestones: 7.0.30, 7.0.31 Dec 17, 2021
@olivere olivere modified the milestones: 7.0.31, 7.x Jan 7, 2022
@olivere
Copy link
Owner Author

olivere commented Mar 31, 2022

As mentioned here, it needs to be renamed to shard_stats (not shards_stats as in my PR).

@olivere olivere modified the milestones: 7.x, 7.0.33 Mar 31, 2022
@olivere olivere self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant