dependencies: heuristic to distinguish host and target artifacts #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Should this go into the changelog? |
RalfJung
force-pushed
the
dependencies
branch
2 times, most recently
from
02c5489 to
37d7e93
Compare
Owner
|
Yea, seems like a good addition for ppl to know that they can do more now |
oli-obk
previously approved these changes
Jul 1, 2025
Collaborator
Author
I'd like to see a release but presumably that's a separate PR? |
Owner
|
Nah just do it in this one. I'll clarify that in the PR description |
RalfJung
force-pushed
the
dependencies
branch
2 times, most recently
from
35ec58d to
ab0d618
Compare
Owner
|
You new ci checks for lockfiles seem to be working |
Collaborator
Author
|
Oddly, a bunch of lockfiles did update when I just changed the version, but the main one did not.^^ |
Collaborator
Author
|
Nothing ensures that the tests have updated lockfiles though... ah well, another time. |
RalfJung
commented
Jul 1, 2025
Collaborator
Author
There was a problem hiding this comment.
This lockfile and ui_test_dep_bug also have some more changes from the "spanned" thing; doesn't seem worth a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327 by looking at the path in which artifacts are stored: if we pass
--targetto cargo, that will be different for host and target crates. If a non-proc-macro host crate shows up, we just ignore it during artifact gathering.I have confirmed that in the context of rust-lang/rust-clippy#14883 this makes the dependency build work.
TODO (check if already done)