Change default fixed suffix to fixed.rs#312
Open
michaelciraci wants to merge 1 commit intooli-obk:mainfrom
Open
Change default fixed suffix to fixed.rs#312michaelciraci wants to merge 1 commit intooli-obk:mainfrom
michaelciraci wants to merge 1 commit intooli-obk:mainfrom
Conversation
michaelciraci
force-pushed
the
suffix-fixed-rs
branch
from
31f6493 to
5d17f71
Compare
oli-obk
reviewed
Apr 14, 2025
| let filename = path.file_name().unwrap().to_string_lossy().to_string(); | ||
|
|
||
| for (from, to) in self.comments().flat_map(|r| match kind { | ||
| _ if kind.ends_with("fixed") => &[] as &[_], |
Owner
There was a problem hiding this comment.
Oh damn, I need to decouple this rust specific logic from the generic logic
Owner
|
Thanks! I think before we can land this old style files should be warned about and just automatically deleted in bless mode Unsure how to best do this. |
Contributor
Author
|
What if we let the fixed suffix be either |
Owner
|
I guess that would work. Basically if there is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288
This changes the default fixed suffix from
fixedtofixed.rsfor IDE rendering.TODO (check if already done)