This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Featured image optimization #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed 'default' named media query which does not exist in Foundation 6. http://foundation.zurb.com/sites/docs/interchange.html#named-media-queries
These variables were added in a previous commit but never referenced in any code. 795804a
Added new image sizes specifically for featured images that are optimized for landscape aspect ratio and updated SCSS for new ratio as well.
Previously the 'single.php' template had the featured image inserted inline as an image tag. Now it shares the same layout used for pages by including 'template-parts/featured-image.php'.
|
Great stuff 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new images sizes specifically for use with featured images on posts/pages. Image sizes are optimized for display in landscape aspect ratios and for HiDPI displays on
smallandmediumscreen sizes. Also updated thesingle.phppost template to use the same full width featured image layout as pages.