Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Removed extra commas, easier child theming #78

Merged
merged 2 commits into from
Jul 23, 2014

Conversation

grantnorwood
Copy link
Contributor

Removed extraneous commas from gruntfile.js. Split out the off-canvas menu and top bar into layout parts for easier customization from a child theme.

@grantnorwood grantnorwood changed the title Removed extraneous commas from end of array items. Removed extra commas, easier child theming Jul 22, 2014
@olefredrik olefredrik merged commit 7f12e87 into olefredrik:master Jul 23, 2014
@Aetles
Copy link
Contributor

Aetles commented Jul 23, 2014

Why remove the commas? Having them there makes it easier to cut and paste lines without having to adjust commas and reduces risk of missing comma errors. Look at the example code here, all trailing commas: http://gruntjs.com/configuring-tasks

@grantnorwood
Copy link
Contributor Author

You're probably right, @Aetles. It's my habit for writing js that's backward-compatible with older browsers, and since I noticed not all object literals in that file had trailing commas I just made it consistent. As node/grunt use a modern version of ECMAscript that supports trailing commas, it wouldn't be terrible to leave those in.

Feel free to make that change and submit a pull request!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants