Added gulp clean tasks #681
Conversation
|
@olefredrik any idea why the build is failing? It just stopped once it hit |
|
Closed and reopened the PR so the tests would run again, hoping that it was something wrong with Travis, but it's still not passing. I get nothing wrong with |
|
@colin-marshall : Seems to be an issue with Travis CI. Related: travis-ci/travis-ci#3358 I'll check what's going on and see how this can be fixed. |
|
Thanks @olefredrik! This can probably get merged in despite the build failing since none of this PR involves php. |
|
@colin-marshall : I did some testing last night, hoping to get some answers for the Travis CI build failure. There is no way the build will pass unless I remove navigation.php. That does really make no sense to me, since the navigation.php has no errors and has previously passed the build without errors. I think it's good to have the WP Coding Standards check as part of the repository, but it's quite unfortunate if it should stop and err on files that are ok. |
|
@olefredrik are there any differences between the CodeSniffing done locally and when it's done on Travis CI? To see if maybe a new WPCS rule was breaking the build, I removed the local CodeSniffing, cleared the composer cache, reinstalled, and tested locally. All CodeSniffs passed with a couple warnings, none of which had to do with |
colin-marshall
force-pushed
the
gulp-clean
branch
from
a09bb06
to
e87d74d
Compare
|
@olefredrik I have narrowed the problem down to the |
colin-marshall
force-pushed
the
gulp-clean
branch
4 times, most recently
from
84722ec
to
f2d3d91
Compare
colin-marshall
force-pushed
the
gulp-clean
branch
from
f2d3d91
to
a880a96
Compare
colin-marshall
force-pushed
the
gulp-clean
branch
from
022760f
to
a8244ca
Compare
|
Finally resolved @olefredrik!!! This is what I came to conclude about the build issue:
While fixing this I noticed that the local wpcs was only checking php files in the root directory of the theme, so I fixed it so that it checks php files in all directories. When running the sniffs locally it didn't stall or give errors when it hit |
| .on('change', function(event) { | ||
| logFileChange(event); | ||
| }); | ||
|
|
||
| // JS Watch | ||
| gulp.watch(['assets/javascript/custom/**/*.js'], ['javascript', 'lint']) | ||
| gulp.watch(['assets/javascript/custom/**/*.js'], ['clean:javscript', 'javascript', 'lint']) |
|
Awesome, Colin!!! Thanks a lot! I'll sit down a few hours this evening and look through all recent issues. Just found a typo in the clean task I think. See comment above. |
Fixes: #680