This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Added Size Class Back Into Image Tag Within Content Body #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 2, 2015 00:15
I agree with most of what this function is doing. However I needed to apply styles to a particular image size within the body of a post and realized that this function completely stripped out any unique identifier that would have allowed me to apply styles to it. So I went ahead and altered the function to include any classes prefixed by “size”. This should allow developers to single out specific sizes within posts and alter the accordingly.
joshrathke
changed the title
olefredrik
added a commit
that referenced
this pull request
Dec 7, 2015
Added Size Class Back Into Image Tag Within Content Body
|
I agree. Thanks, @josh-rathke 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely up for a debate on this one, but I think the image size is worth preserving within the image tag for styling purposes. It really doesn't add very much bulk at all, and doesn't cause any responsive conflicts. I also took the liberty of simplifying the function a little bit by simply checking for the "align" and "size" prefix, rather than having a static array of entries. Should prove to be a little more dynamic that way.