Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Added grunt-browser-sync #528

Merged
merged 2 commits into from
Oct 30, 2015
Merged

Conversation

colin-marshall
Copy link
Collaborator

If interested, I added grunt-browser-sync to FoundationPress. To use, just open the Gruntfile and fill in the host in the proxy field of the browser-sync task. Running the default task will start the browser-sync and watch tasks.

@olefredrik
Copy link
Owner

Thanks for good input. My concern is that people who are not already using browser-sync will find it difficult to get started. I envision a storm of issues around proxies, ports etc. It is nevertheless possible to use standalone plugins such as LiveReload for Chrome, which does not require manual setup and grunt tasks.

@colin-marshall
Copy link
Collaborator Author

I hear you. The manual install is pretty simple 1 step process though. If you already have a local WP install running you just plug in the address you use to visit the local site into the proxy field and it should work out of the box. Adding browser-sync does not interfere with LiveReload. They can co-exist. There are many things browser-sync does that LiveReload does not, so why not offer both?

I added a new commit that took browser-sync off of the default grunt task and gave it its own "browser-sync" grunt task which runs browser-sync and then the watch task. Figured it would be better not to force it on people since LiveReload has been implemented already.

The main downside I see is that it adds an npm dependency.

olefredrik added a commit that referenced this pull request Oct 30, 2015
@olefredrik olefredrik merged commit d8485ef into olefredrik:master Oct 30, 2015
@olefredrik
Copy link
Owner

👍

@colin-marshall colin-marshall deleted the browser-sync branch December 15, 2015 04:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants