This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Fix out-of-the-box behavior of mobile layout #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we just install the theme and do not change the mobile layout and menu position in the customizer, these theme mods return false. Added handling for this so that when the mobile menu layout is false, the off canvas will be shown; when the mobile menu position is false, the left position will be used.
|
Hi @skoldin , thank you for this!! Would you be able to fix the build errors commit and push? |
When we just install the theme and do not change the mobile layout and menu position in the customizer, these theme mods return false. Added handling for this so that when the mobile menu layout is false, the off canvas will be shown; when the mobile menu position is false, the left position will be used.
olefredrik
added a commit
that referenced
this pull request
Sep 22, 2015
Fix out-of-the-box behavior of mobile layout
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we just install the theme without changing the mobile
layout and menu position in the customizer, mobile menu layout
and position theme mods return false.
Added handling for this so that when the mobile menu layout is
false, the off canvas will be shown; when the mobile menu position is
false, the left position will be used.