This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Fix php error in asset_path function #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
library/enqueue-scripts.php
Outdated
| @@ -15,7 +15,8 @@ | |||
|
|
|||
| if ( ! function_exists( 'foundationpress_asset_path' ) ) : | |||
| function foundationpress_asset_path( $filename ) { | |||
| $dir = end( explode ( '.' , $filename) ); | |||
| $tmp = explode('.', $filename); | |||
There was a problem hiding this comment.
@JPOak please push another commit with the following changes:
- Let's use a more descriptive name than
$tmp. Change it to$filename_split. - Put spaces after opening parentheses and before closing parentheses.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1128 Fix error. Ahhhhh.