Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallocate #24

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Fallocate #24

merged 2 commits into from
Aug 28, 2018

Conversation

mjbach
Copy link
Collaborator

@mjbach mjbach commented Aug 28, 2018

Added graceful failure for bad CLI args. Also added fallocate support if it is found.

@mjbach mjbach merged commit 0998576 into olcf:master Aug 28, 2018
fwang2 added a commit to fwang2/lcio that referenced this pull request Aug 29, 2018
mjbach added a commit that referenced this pull request Aug 29, 2018
add posix_fallocate check, #24
@fwang2
Copy link
Contributor

fwang2 commented Aug 29, 2018

well, there is still an issue with this implementation:
apparently, due to missing HAVE_ def, this code was never compiled.

/usr/include/fcntl.h:290:12: note: declared here
 extern int __REDIRECT (posix_fallocate, (int __fd, __off64_t __offset,
            ^
/gpfs/alpinetds/stf008/scratch/fwang2/lcio/lib/posix.c:61:13: error: too few arguments to function ‘posix_fallocate’
             *rv = posix_fallocate(*(int*)fdes, flag);
             ^
In file included from /usr/include/features.h:375:0,
                 from /usr/include/sys/stat.h:26,
                 from /gpfs/alpinetds/stf008/scratch/fwang2/lcio/lib/posix.c:1:
/usr/include/fcntl.h:290:12: note: declared here
 extern int __REDIRECT (posix_fallocate, (int __fd, __off64_t __offset,

fwang2 added a commit to fwang2/lcio that referenced this pull request Aug 29, 2018
fwang2 added a commit to fwang2/lcio that referenced this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants