-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React vite webview #106
Open
darkelfs56
wants to merge
12
commits into
olasunkanmi-SE:development
Choose a base branch
from
darkelfs56:react-vite-webview
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
React vite webview #106
darkelfs56
wants to merge
12
commits into
olasunkanmi-SE:development
from
darkelfs56:react-vite-webview
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getWebviewContent that expects Webview and Uri types from "vscode"
- Modified localResourceRoots to include related files for using folder "webview-ui" - Commented out knowledgeBaseDocs code because not sure how to do it. - Add setInterval every 3 seconds that will call getChatCss and postMessage to react webview-ui if any changes to update the current stylings.
- components folder that currently only have ChatWindow.tsx - hooks folder that currently only have useWebviewMessages function to listen to message sent by extensio to update chat window css. - vite.config.ts modified to output build folder that can be used and joined with the vscode extension Uri path.
HI @darkelfs56, Akmal, I appreciate this contribution. I will look into the PR. Thanks buddy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Ola, this is me Akmal again.
I'm making this PR that implements React with Vite for Codebuddy extension webview.
I was actually following this simple video here
Related repos mentioned in the video as references are:
Also, I have this video of mine here that shows that the extension webview is indeed using React now.
The video is made unlisted, so only those who have the link can view it.
(Video link here)[https://youtu.be/2D6g_15--hc]
Issues
The only issues that I had was that apparently, I cannot make use of getConfigValues, or rather cannot make use of anything from the "vscode" library for building the React with Vite webview, because if you see on the package.json file itself, the "vscode" library is NOT an npm package but rather like an internal library that works inside vscode only.