Skip to content

Sync power state for HEOS models (2016+)#49

Merged
ol-iver merged 1 commit intool-iver:masterfrom
klada:master
Jun 9, 2018
Merged

Sync power state for HEOS models (2016+)#49
ol-iver merged 1 commit intool-iver:masterfrom
klada:master

Conversation

@klada
Copy link
Copy Markdown
Contributor

@klada klada commented Jun 8, 2018

On newer models the power state is not updated in _update_avr_2016.

Closes #48

See home-assistant/core#14792

Comment thread denonavr/denonavr.py Outdated
"Input function list for Denon receiver at host %s "
"could not be updated."), self._host)

# Now playing information is not implemented for 2016+ models, because a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

Comment thread denonavr/denonavr.py Outdated
_LOGGER.error((
"Input function list for Denon receiver at host %s "
"could not be updated."), self._host)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

@klada klada force-pushed the master branch 2 times, most recently from 27b08a4 to d1de1a5 Compare June 8, 2018 20:49
@ol-iver
Copy link
Copy Markdown
Owner

ol-iver commented Jun 9, 2018

Please fix the lint issues before I merge it. Thanks

@klada
Copy link
Copy Markdown
Contributor Author

klada commented Jun 9, 2018

@scarface-4711 done. It would be cool if you could bump the version in the foreseeable future, so Home Assistant can benefit from this fix 😄

@ol-iver ol-iver merged commit a822c91 into ol-iver:master Jun 9, 2018
@ol-iver
Copy link
Copy Markdown
Owner

ol-iver commented Jun 9, 2018

@klada there is version 0.7.3 now.
Do you want to include it to HA or should I?

@klada
Copy link
Copy Markdown
Contributor Author

klada commented Jun 10, 2018

@scarface-4711 Thanks, I'll prepare a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants