poc: Use minimal okta-auth-js IDX client #3419
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| include: [ | ||
| /node_modules\/@okta\/okta-auth-js/, | ||
| ], | ||
| sideEffects: false, |
There was a problem hiding this comment.
This is important for proper tree-shaking
| @@ -320,10 +320,8 @@ test.requestHooks(requestLogger, mockEnrollAuthenticatorPhoneSmsInvalidPhone)('s | |||
| await t.expect(req3Body?.authenticator?.phoneNumber).eql('+1123'); | |||
| await t.expect(req3Body?.stateHandle).notEql(undefined); | |||
|
|
|||
| // in gen 2 we re-introspect when clicking return to authenticator, | |||
There was a problem hiding this comment.
Fixed in okta/okta-auth-js#1426
| @@ -98,7 +99,6 @@ Expect.describe('v1/LoginRouter', function() { | |||
| router.on('afterError', afterErrorHandler); | |||
| if (authClient) { | |||
| spyOn(authClient.token, 'getWithoutPrompt').and.callThrough(); | |||
| spyOn(authClient.token.getWithRedirect, '_setLocation'); | |||
There was a problem hiding this comment.
_setLocation has been removed in okta/okta-auth-js#1324
denysoblohin-okta
force-pushed
the
od-test-bundle-idx-lite
branch
4 times, most recently
from
4c54151
to
79e27c3
Compare
denysoblohin-okta
force-pushed
the
od-test-bundle-idx-lite
branch
4 times, most recently
from
2d415f4
to
5cf248f
Compare
AUTHJS_VERSION="7.5.0-ga548153" use idx as before, but create own lite OktaAuthClient use 7.5.0-g5555ddd fix test fix test fix test type fixes lint fix fix lint trigger test 7.5.0-g5ab8355 increase timeout
This reverts commit c5b0a21.
. . . .
denysoblohin-okta
changed the title
denysoblohin-okta
force-pushed
the
od-test-bundle-idx-lite
branch
from
8e97a72
to
7d0e238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use client from okta/okta-auth-js#1476
Size comparison:
Before:
After:
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: