-
Notifications
You must be signed in to change notification settings - Fork 45
feat(arch): add support new arch #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rajdeepnanua-okta can u review this PR? |
|
Hi @ngocle2497, thanks for contributing this PR! It will take some time for me to review this PR given the size. But I have a few comments/questions:
I will review this in more details soon. But after a quick glance at your PR, everything else seems to be looking good. Thanks again for your contribution! |
|
|
Hi @ngocle2497, I've merged your changes into a local feature branch. I'm going to do a couple sanity checks to make sure everything is working properly, and will then release the changes into master. Thanks again for the changes! |
|
@rajdeepnanua-okta as far as I can tell this change hasnt been included in a new release yet, do you have any insight into when that will be published? |
|
@rajdeepnanua-okta Can you confirm whether these changes were ever published as a part of a release? Meta will be freezing support for the legacy architecture very soon so it is going to be critical to get this library up to date with new arch support. |
Add support new arch for android + ios