-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native callbacks instead of promise in createConfig #404
Conversation
97869b3
to
fd592da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Are you planning to trigger a release for this, to enable testing of this update?
Yep. @shuowu-okta can help us with releasing this. I'll add the release docs |
@rajdeepnanua-okta great work on this PR! I see that here Line 140 in fd592da
createConfig is still marked as async call but there's nothing in the function itself that will follow the async/await pattern anymore.
I see that And when I've tried calling createConfig like this:
I started getting the fillowing error (it worked just fine in previous releases):
|
I can confirm I also have the same error:
|
@chukcha-wtf, the createConfig function contract remains the same as before. It's using callbacks internally, and the changes don't affect the API exposed to you. |
I am experiencing this issue on IOS but I don't think it is connected to this MR. It's happening on older versions too. -----> Not true, see EDIT below. It started when i upgraded this lib earlier today so my error search brought me to this MR. EDIT: Actually it only happens on I managed to make it work on |
@chukcha-wtf, @nikolal, we have released 2.11.1 which fixes issues with iOS, and also some hard to hit issues for Android. Let me know if it helps |
No description provided.