Ensure token item and metadata keychain accessibility settings are consistent. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent. This addresses #198 by: 1. Ensuring the token metadata is stored with the appropriate accessibility settings, respecting the parent item's iCloud sync setting. 2. Returning token IDs only if both their item and metadata keychain entries can be found. 3. Establishing the `Credential.Security.isDefaultSynchronizable` property, allowing the default identifier to be shared. This also adds unit test coverage to validate these changes.
This was referenced Jul 17, 2024
rajdeepnanua-okta
approved these changes
Jul 18, 2024
baksha97
reviewed
Jul 18, 2024
Comment on lines
-49
to
+58
| return try Keychain | ||
| let itemIDs = try Keychain | ||
| .Search(service: KeychainTokenStorage.serviceName) | ||
| .list() | ||
| .sorted(by: { $0.creationDate < $1.creationDate }) | ||
| .map(\.account) | ||
| let metadataIDs = try Keychain | ||
| .Search(service: KeychainTokenStorage.metadataName) | ||
| .list() | ||
| .map(\.account) | ||
| return itemIDs.filter { metadataIDs.contains($0) } |
There was a problem hiding this comment.
Does this prevent the find function from short circuiting for users already missing items/tokens?
There was a problem hiding this comment.
@baksha97 correct, this ensures that only tokens that have both their metadata and item keychain entries available to the device will be returned. Therefore, the find and other functions will succeed.
This will still allow legitimate errors (such as an unsuccessful biometric prompt) to flow through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #198 by:
Credential.Security.isDefaultSynchronizableproperty, allowing the default identifier to be shared.This also adds unit test coverage to validate these changes.