Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent cache locking when read and allow config timeout for cache #92

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

duytiennguyen-okta
Copy link
Contributor

No description provided.

Copy link
Contributor

@MikeMondragon-okta MikeMondragon-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be a release, so you'll need to update the CHANGELOG.md file. We don't manage the version in code, it is done with a vMAJOR.MINOR.BUILD formatted tag that triggers goreleaser . I propose the release have the minor version bumped so the version will be 1.4.0. This is because the public method Cache has change on JwtVerifier to Cache func(func(string) (interface{}, error), time.Duration, time.Duration) (utils.Cacher, error) . So the CHANGELOG.md entry should call out the two significant changes - the change to the Cache method, and customizable expiry.

Also, the README.md needs to be updated and improved. In the Customizable Resource Cache section should document how JwtVerifier's default cache is the utils.NewDefaultCache and also the meaning of each of the parameters to the method itself.

@monde monde self-requested a review January 4, 2023 23:50
@MikeMondragon-okta MikeMondragon-okta merged commit 06f5827 into master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants