Introduce generic support for supplying a recovery token when initiating an IDXClient #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenachbaur-okta
requested review from
oleggnidets-okta and
jaynewstrom-okta
JayNewstrom
approved these changes
Dec 21, 2021
| /// - completion: Completion block to be invoked when a client is created, or when an error is received. | ||
| public static func start(with configuration: Configuration, | ||
| state: String? = nil, | ||
| options: [Option:String]? = nil, |
There was a problem hiding this comment.
Is this a breaking API change? (I think it is, which is why I'm asking)
There was a problem hiding this comment.
This is technically a breaking change, though the 2.0.0 release was just cut recently which introduced even more significant breaking changes. Since this argument is optional, and very few people will actually use it, I'm okay with just doing a minor version change for this update.
Co-authored-by: Jay Newstrom <[email protected]>
jaynewstrom-okta
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.