Add DT cookie and fix IDX for org auth servers #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenachbaur-okta
previously approved these changes
Jun 13, 2024
| @@ -41,10 +41,11 @@ import com.okta.idx.kotlin.dto.v1.Response as V1Response | |||
| /** | |||
| * The InteractionCodeFlow class is used to define and initiate an authentication workflow utilizing the Okta Identity Engine. | |||
| */ | |||
| class InteractionCodeFlow constructor(private val client: OAuth2Client) { | |||
| class InteractionCodeFlow(private val client: OAuth2Client) { | |||
There was a problem hiding this comment.
I'm curious, is there a reason why the OAuth2Client is private? My Kotlin may be a bit rusty, but this will make it inaccessible to see by the developer, correct?
There was a problem hiding this comment.
That's correct. It's more of a legacy than an intentional decision to keep this private. I didn't think much about making this public because the developer can provide their own client to the constructor and have it available to them anyways. And it's also accessible to the developer through OAuth2Client.default if they construct the flow using the empty constructor. I can make this public
rajdeepnanua-okta
force-pushed
the
dt_cookie
branch
from
8cf4e97
to
329c46c
Compare
mikenachbaur-okta
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DT cookie to IDX SDK. This is done mostly by copying the implementation from okta-mobile-kotlin code during the time of this PR: okta/okta-mobile-kotlin@cd65552
I have also added additional tests not present in okta-mobile-kotlin originally.
This PR also adds a small fix for using IDX using org auth servers, when the issuer url doesn't contain /oauth2 in the path