Add support to pass callback to poll function #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If a callback is passed to polling function during mfa challenge, the callback is invoked on every successful poll with the transaction as argument. * This is needed to know if the response info changed during poll. eg) OV risk scoring number challenge flow.
| @@ -0,0 +1,82 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
There was a problem hiding this comment.
is this the first test using jest? can we have jasmine and jest in this repo with no prob? or should we stick to jasmine for now?
There was a problem hiding this comment.
I think all the tests are moved to jest already. I guess this is the first one using snapshots.
The jasmine based tests are under https://github.com/okta/okta-auth-js/tree/master/test/karma
swiftone
reviewed
Sep 23, 2019
| }, | ||
| expectations: function (test) { | ||
| expect(test.transactionCallbackFn.calls.count()).toBe(2); | ||
| expect(test.transactionCallbackFn.calls.argsFor(0)[0]).toMatchSnapshot(); |
There was a problem hiding this comment.
I have not yet grokked util.itMakesCorrectRequestResponse yet, but why test for two calls and then only match the snapshot for one?
There was a problem hiding this comment.
the responses that we get during the poll is same in this case as this is just polling.
swiftone
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a callback is passed to polling function during mfa challenge, the callback is invoked on
every successful poll with the transaction as argument.
This is needed to know if the response info changed during poll.
eg) OV risk scoring number challenge flow.
https://okta.app.box.com/s/yhybly12s4jne89fsoc41rgkqxpmd2g8