Pkce2 #210
Merged
Pkce2 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongranick-okta
requested review from
robertjd,
manueltanzi-okta,
jmelberg-okta and
nbarbettini
aarongranick-okta
added a commit
that referenced
this pull request
Jun 3, 2019
* wip * cleanup, fix * cleanup / reduce * simple test app, performs PKCE flow * lint * fix tests * npm start * save / load code verifier * polyfill webcrypto, TextEncoder to test computeChallenge * Add options to util: - generateIDtoken - bypassCrypto (will "ignoreSignature") - option for timeout on test - responseVars for XHR templates * test exchangeFortoken, fix minor bug * cleanup, fix tests * address review feedback * changes needed for fetch to handle token post * validate response types (allow 'code' in array) * Pkce2 (#210) * streamline pkce * fix/disable tests * PKCE flow configured by "grantType: authorization_code" on getWithRedirect * Update README.md * Add unit test for fetch request. Explicitly mock cross-fetch where needed. * enable tests (defaults to fragment mode for code now) * address review feedback * Add karma test for crypto/pkce which needs webcrypto Removes "peculiar" polyfill * browser tests for complete login flow, implicit & pkce * fix karma test * update README from review feedback * Adds tests for "validateOptions" * remove package-lock.json from test/app * use --prefix (easier to understand) * do not export pkce interface * fix test app * validate code_challenge_method against well-known configuration * verify functionality of getWithPopup() for PKCE and implicit * fix tests * support PKCE directly in getToken (for popup, frame, etc.) * Use crypto to generate super random string for verifier * remove breaking change: responseMode * Add tests for renew token * add test for error/iframe offline_access * nits * throw if using undefined storage name key * add method to test for PKCE support (+tests for features) * Add PKCE paragraph to README * withCredentials for reqwest / jquery httpRequestClients * remove features from server test * Throw error if trying to use PKCE on unsupported browser * Update README.md * PKCE supported: only throw in constructor * lint nits * Accept more query params in test app * nit * small fix for testApp * set values for scopes, responseType in test * udpate test app readme * disallow "code" responseType * add tests for base64 utils * review feedback * expect responseType=code when grantType=authorization_code * nits * getToken*: throw if PKCE not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the PKCE flow so that it matches the implicit flow (from the point of view of the customer). As with implicit flow, it begins with a call to
getWithRedirect(), then on the callback pageparseFromURL()will return the tokens.With the changes in this PR, all that is necessary is to pass
grantType: 'authorization_codetogetWithRedirect.Approving this PR will merge it into the PKCE branch (which is still pending review). There are still a few items to take care of before this feature is ready for final review. Here we are mostly looking for feedback on the external api.
abd878f