OKTA-716396 : fix : add condition to compare stateHandles when loading saved idxResponse only when useGenericRemediator option is false or undefined #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenfannin-okta
force-pushed
the
OKTA-716396-saveidxresponse-fix
branch
from
4d803fe
to
35acb3c
Compare
glenfannin-okta
changed the title
jaredperreault-okta
previously approved these changes
Apr 30, 2024
glenfannin-okta
changed the title
glenfannin-okta
changed the title
glenfannin-okta
force-pushed
the
OKTA-716396-saveidxresponse-fix
branch
from
19dd995
to
9b4777b
Compare
glenfannin-okta
changed the title
jaredperreault-okta
approved these changes
May 2, 2024
jaredperreault-okta
approved these changes
May 2, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this ticket is to add conditional logic on whether or not we should check the stateHandle between what is saved and the stateHandle from the most recent response.
This change was made for Gen 3 in this PR #1359 which does not work for Gen 2 (when not using Generic Remediator).