fix: UA string in Node no longer continuously extends #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/spec/OktaUserAgent.ts
Outdated
| beforeEach(() => { | ||
| jest.spyOn(mocked.features, 'isBrowser').mockReturnValue(false); | ||
| mocked.isBrowser.mockReturnValue(false); | ||
| (global as any).node = NODE_VERSION; |
There was a problem hiding this comment.
What does this line do? As I understand, Node version is being read from process.versions.node
There was a problem hiding this comment.
That line actually does nothing, I just tested it 🤦
There was a problem hiding this comment.
remove before merging if it's not doing anything
shawyu-okta
reviewed
Aug 25, 2023
Comment on lines
+1
to
+2
| const SDK_VERSION = (global as any).SDK_VERSION; | ||
| const NODE_VERSION = (global as any).NODE_VERSION; |
There was a problem hiding this comment.
Could we augment the global type locally with these variables so we don't need to cast to any?
shawyu-okta
approved these changes
Aug 25, 2023
test/spec/OktaUserAgent.ts
Outdated
| beforeEach(() => { | ||
| jest.spyOn(mocked.features, 'isBrowser').mockReturnValue(false); | ||
| mocked.isBrowser.mockReturnValue(false); | ||
| (global as any).node = NODE_VERSION; |
There was a problem hiding this comment.
remove before merging if it's not doing anything
denysoblohin-okta
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.