-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enroll Authenticator via /authorize #1324
Merged
eng-services-aperture-github-bot-okta
merged 11 commits into
master
from
od-mfa_enroll-OKTA-539548
Dec 14, 2022
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a3449d6
wip
denysoblohin-okta 1055fd3
added unit tests
denysoblohin-okta 4e8d57e
moved enrollAuthenticator to top level
denysoblohin-okta f84ede2
added handleRedirect
denysoblohin-okta a3e6895
get rid of _setLocation
denysoblohin-okta f58e380
added feature
denysoblohin-okta 09a32a6
refactor, avoid explicit cast
aarongranick-okta 9b50738
test with and without setLocation
denysoblohin-okta 9a67101
refactor: endpoints.autorize.enrollAuthenticator
denysoblohin-okta 8b6c09c
e2e
denysoblohin-okta 738ad21
chlog, readme
denysoblohin-okta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* eslint-disable @typescript-eslint/no-non-null-assertion */ | ||
/*! | ||
* Copyright (c) 2015-present, Okta, Inc. and/or its affiliates. All rights reserved. | ||
* The Okta software accompanied by this notice is provided pursuant to the Apache License, Version 2.0 (the "License.") | ||
* | ||
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0. | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* | ||
* See the License for the specific language governing permissions and limitations under the License. | ||
* | ||
*/ | ||
import { OktaAuthOAuthInterface, EnrollAuthenticatorOptions } from './types'; | ||
import { clone } from '../util'; | ||
import { prepareEnrollAuthenticatorParams, createEnrollAuthenticatorMeta } from './util'; | ||
import { buildAuthorizeParams } from './endpoints/authorize'; | ||
|
||
export function enrollAuthenticator( | ||
sdk: OktaAuthOAuthInterface, | ||
options: EnrollAuthenticatorOptions | ||
): void { | ||
options = clone(options) || {}; | ||
|
||
const params = prepareEnrollAuthenticatorParams(sdk, options); | ||
const meta = createEnrollAuthenticatorMeta(sdk, params); | ||
const requestUrl = meta.urls.authorizeUrl + buildAuthorizeParams(params); | ||
sdk.transactionManager.save(meta); | ||
if (sdk.options.setLocation) { | ||
sdk.options.setLocation(requestUrl); | ||
} else { | ||
window.location.assign(requestUrl); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Does empty scope query parameter have a special meaning to the authorize endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For authenticator enrolment via authorize endpoint
scope
should be deleted.https://github.com/okta/okta-auth-js/pull/1324/files#diff-c7c807658c1f989f83fd7287c01e1c459ffa33b5afc14bb32dc9bd23b51e0048R39