Provide option to skip idToken signature validation #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jmelberg-okta
force-pushed
the
jm-token-validation
branch
from
f84b16e
to
386a287
Compare
jmelberg-okta
force-pushed
the
jm-token-validation
branch
from
386a287
to
f1ad98d
Compare
jmelberg-okta
force-pushed
the
jm-token-validation
branch
3 times, most recently
from
f798546
to
825f307
Compare
jmelberg-okta
commented
Jul 25, 2018
lib/clientBuilder.js
Outdated
| @@ -78,6 +78,10 @@ function OktaAuthBuilder(args) { | |||
| this.options.maxClockSkew = args.maxClockSkew; | |||
| } | |||
|
|
|||
| // Give the developer the ability to disable token signature | |||
| // validation. | |||
| this.options.ignoreSignature = args.ignoreSignature === true ? true : false; | |||
There was a problem hiding this comment.
This can be simplified to !!args.ignoreSignature
jmelberg-okta
force-pushed
the
jm-token-validation
branch
6 times, most recently
from
a0bc65e
to
f3751dc
Compare
jmelberg-okta
force-pushed
the
jm-token-validation
branch
from
f3751dc
to
907641e
Compare
robertjd
reviewed
Aug 7, 2018
lib/oauthUtil.js
Outdated
| if (!claims || !iss || !aud) { | ||
| throw new AuthSdkError('The jwt, iss, and aud arguments are all required'); | ||
| } | ||
|
|
||
| if (nonce && claims.nonce !== nonce) { | ||
| if (validationParams.nonce && claims.nonce !== validationParams.nonce) { |
There was a problem hiding this comment.
If we're going to destrcture aud and iss, let's do the same for nonce
lib/token.js
Outdated
| @@ -48,12 +48,14 @@ function verifyToken(sdk, token, nonce, ignoreSignature) { | |||
|
|
|||
| var jwt = decodeToken(token.idToken); | |||
|
|
|||
| var validationOptions = oauthUtil.getDefaultValidationParams(sdk, validationParams); | |||
There was a problem hiding this comment.
Is this broken out to a function for test purposes? I ask because it feels like it would be more clear to just have the defaults as a literal, and then extend it with the incoming options. Having "get" functions that mutate their arguments never feel great.
| @@ -78,6 +78,10 @@ function OktaAuthBuilder(args) { | |||
| this.options.maxClockSkew = args.maxClockSkew; | |||
| } | |||
|
|
|||
| // Give the developer the ability to disable token signature | |||
| // validation. | |||
| this.options.ignoreSignature = !!args.ignoreSignature; | |||
There was a problem hiding this comment.
Offline conversation: add this to README
jmelberg-okta
force-pushed
the
jm-token-validation
branch
from
13ffd77
to
cc4ef89
Compare
jmelberg-okta
added a commit
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grants developers the ability to disable
idTokensignature validation for testing purposes and browser support.Usage
The
ignoreSignatureparam can be passed in during either client configuration or token validation.Client configuration
Token validation
Resolves