Add test apps for all supported angular version #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
force-pushed
the
sw-add-test-apps
branch
from
1666e92
to
10938e0
Compare
shuowu
requested review from
aarongranick-okta,
jaredperreault-okta,
oleksandrpravosudko-okta and
denysoblohin-okta
3 tasks
build2/reports/e2e/junit-results.xml
Outdated
| @@ -0,0 +1,507 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
should this be committed?
scripts/prepare-test-apps.sh
Outdated
| npx yalc publish | ||
| popd | ||
|
|
||
| # npx lerna exec -- yarn install --frozen-lockfile |
There was a problem hiding this comment.
remove comment
jaredperreault-okta
approved these changes
Nov 30, 2021
| @@ -0,0 +1 @@ | |||
| npx lerna exec -- npx yalc remove --all | |||
There was a problem hiding this comment.
you can use yarn instead of npx. npx might install a package using npm which could cause an issue
There was a problem hiding this comment.
yarn removes -- in the command, which makes it cannot be executed. Also, since this command is just for no-hoisted packages, the package manager should not matter that much.
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Dec 1, 2021
BREAKING CHANGE: use OKTA_AUTH injection token to inject oktaAuth instance (#79) * fixes prod build issue by introducing OKTA_AUTH injection token * add test apps * add changelog & migrating guide * add test apps readme OKTA-435165 <<<Jenkins Check-In of Tested SHA: 7b7fe1c for [email protected]>>> Artifact: okta-angular Files changed count: 286 PR Link: "#80"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
oktaAuthinstance withOKTA_AUTHinjection tokenlite-serveris added to serve the static assets.Todo: