Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test apps for all supported angular version #79

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Nov 19, 2021

Changes:

  • Fixes angular 7 & 8 prod build issue by injecting oktaAuth instance with OKTA_AUTH injection token
  • Adds test apps for angular version 7 - 13
  • Runs e2e against prod build instead of in dev mode, lite-server is added to serve the static assets.
  • Migrates protractor -> wdio

Todo:

  • Add codegen in repo to manage test apps cross all angular versions.

@@ -0,0 +1,507 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be committed?

npx yalc publish
popd

# npx lerna exec -- yarn install --frozen-lockfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

@@ -0,0 +1 @@
npx lerna exec -- npx yalc remove --all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use yarn instead of npx. npx might install a package using npm which could cause an issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn removes -- in the command, which makes it cannot be executed. Also, since this command is just for no-hoisted packages, the package manager should not matter that much.

@shuowu-okta shuowu-okta merged commit 7b7fe1c into dev-5 Dec 1, 2021
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Dec 1, 2021
BREAKING CHANGE: use OKTA_AUTH injection token to inject oktaAuth instance (#79)

* fixes prod build issue by introducing OKTA_AUTH injection token
* add test apps
* add changelog & migrating guide
* add test apps readme

OKTA-435165
<<<Jenkins Check-In of Tested SHA: 7b7fe1c for [email protected]>>>
Artifact: okta-angular
Files changed count: 286
PR Link: "#80"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants