Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Usage in README.md #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Usage in README.md #52

wants to merge 2 commits into from

Conversation

pa-do
Copy link

@pa-do pa-do commented Jan 25, 2021

I found an error while executing an usage of a README.md. And I found what the problem is. It would be helpful to reflect this in the document.

@pa-do pa-do mentioned this pull request Jan 25, 2021
Open
okonet
okonet requested changes Jan 25, 2021
View reviewed changes
Copy link
Owner

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's correct. The example uses a class component but you replaced render method to return without updating the rest of it.

@pa-do
Copy link
Author

pa-do commented Jan 25, 2021

Then you need to check about ); at line 48.
There is no opening parenthesis here.

@okonet
Copy link
Owner

okonet commented Jan 25, 2021

Sorry I don't understand that. Maybe it is better to drop those examples for good since we have working examples in the styleguide?

@pa-do
Copy link
Author

pa-do commented Jan 25, 2021

If you think it's better, do it.

@okonet
Copy link
Owner

okonet commented Jan 25, 2021

Well, you reported an issue so I'd expect you to finish it. I'd be also interested in what you think would be better for developers like you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okonet okonet okonet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pa-do @okonet @joaogardenberg