Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe markdown configuration #645

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Add unsafe markdown configuration

Which issue this PR fixes:
fixes #638

Release note:

- Support the latest version of Hugo

@mpourismaiel mpourismaiel added the deps_hugo hugo dependency compatability issues label Dec 3, 2019
@mpourismaiel mpourismaiel added this to the v0.16.0 milestone Dec 3, 2019
@mpourismaiel mpourismaiel requested a review from stp-ip December 3, 2019 17:56
@mpourismaiel mpourismaiel self-assigned this Dec 3, 2019
@ghost
Copy link

ghost commented Dec 3, 2019

DeepCode Report (#066121)

DeepCode analyzed this pull request.
There are no new issues.

@stp-ip
Copy link
Member

stp-ip commented Dec 3, 2019

/hold

I dislike us using an option that already is named "unsafe"...

@mpourismaiel
Copy link
Member Author

This is a temporary fix only to add support for 0.60 a bit faster since we already don't support v0.59 and the fix is only added to the development config. I created a tracking issue for a permanent and more sane solution #646.

@stp-ip
Copy link
Member

stp-ip commented Dec 3, 2019

Fair point. As long as we remove it for the release.

@stp-ip stp-ip merged commit 4b4271b into okkur:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps_hugo hugo dependency compatability issues
Development

Successfully merging this pull request may close these issues.

Syna is not fully compatible with Hugo 0.60.0 new markdown render
2 participants