Skip to content

Check the current dev CI#2

Closed
okathira wants to merge 3 commits intodevfrom
dev-ci-test
Closed

Check the current dev CI#2
okathira wants to merge 3 commits intodevfrom
dev-ci-test

Conversation

@okathira
Copy link
Owner

Fixes #???

What is the purpose of this PR?

  • Fix bug
  • Fix typo
  • Update specs
  • Add new rule
  • Add new parser
  • Improve or refactor rules
  • Add a new core feature
  • Improve or refactor core features
  • Update documents
  • Others

Description

Checklist

Fill out the checks for the applicable purpose.

@okathira okathira changed the title Update README.md Check the current dev CI Mar 11, 2024
@okathira
Copy link
Owner Author

okathira commented Mar 13, 2024

@okathira
Copy link
Owner Author

@okathira
Copy link
Owner Author

okathira commented Mar 13, 2024

I have got details of results on CI of Node v20 or higher, like https://github.com/okathira/markuplint/actions/runs/8256506493/job/22585352968

Error: Cannot find package '/home/runner/work/markuplint/markuplint/packages/@markuplint/file-resolver/node_modules/minimatch/package.json' imported from /home/runner/work/markuplint/markuplint/packages/@markuplint/file-resolver/lib/ml-file/get-files.js
Did you mean to import minimatch/dist/cjs/index.js?
    at legacyMainResolve (node:internal/modules/esm/resolve:214:26)
    at packageResolve (node:internal/modules/esm/resolve:840:14)
    at moduleResolve (node:internal/modules/esm/resolve:910:20)
    at defaultResolve (node:internal/modules/esm/resolve:[113](https://github.com/okathira/markuplint/actions/runs/8256506493/job/22585352968#step:7:114)0:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Maybe this is the cause of all failures.
tested here https://github.com/okathira/markuplint/actions/runs/8267321414

@okathira
Copy link
Owner Author

isaacs/minimatch#189
but minimatch supports esm already...?

@okathira
Copy link
Owner Author

isaacs/minimatch#224
isaacs/minimatch#225
same import problems?

@okathira okathira closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant