Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2520 - Sentence is cut off in the payment-streak tooltip #2531

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

SebinSong
Copy link
Collaborator

closes #2520

[ Fix screenshot ]


This regression was introduced by the fix for #2249 which is something we must keep too. So as a fix, I created a boolean prop named noEllipsis that allows to opt out of this fix.

@SebinSong SebinSong self-assigned this Jan 21, 2025
Copy link

cypress bot commented Jan 21, 2025

group-income    Run #3779

Run Properties:  status check passed Passed #3779  •  git commit 1d45b4fbf1 ℹ️: Merge 0be67389ddfb148e2bbecf80daec3dafa8c6210d into faadd19b4018a53bda70f8eb5eb4...
Project group-income
Branch Review sebin/task/#2520-tooltip-cut-off
Run status status check passed Passed #3779
Run duration 10m 49s
Commit git commit 1d45b4fbf1 ℹ️: Merge 0be67389ddfb148e2bbecf80daec3dafa8c6210d into faadd19b4018a53bda70f8eb5eb4...
Committer Sebin Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @SebinSong!

Can you please check all of the other places where this new flag is needed and add it?

For example, it's clearly needed here too:

Screenshot 2025-01-20 at 7 49 17 PM

@SebinSong
Copy link
Collaborator Author

SebinSong commented Jan 22, 2025

@taoeffect
I can't reproduce that issue. As you can see from below screenshots below, multiple items are not cut off.

By using real-db:

I believe this issue has been fixed by below rule in this previous commit.

.c-anchored-tooltip {
  ...
  height: max-content;
}

Once it's ensured you are testing in sebin/task/#2520-tooltip-cut-off branch, It believe the bug is gone.

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and it seems to work! Nice job!

@taoeffect taoeffect merged commit 80397f4 into master Jan 22, 2025
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2520-tooltip-cut-off branch January 22, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: tooltip showing streaks is cut off
2 participants