-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2520 - Sentence is cut off in the payment-streak tooltip #2531
Conversation
group-income Run #3779
Run Properties:
|
Project |
group-income
|
Branch Review |
sebin/task/#2520-tooltip-cut-off
|
Run status |
Passed #3779
|
Run duration | 10m 49s |
Commit |
1d45b4fbf1 ℹ️: Merge 0be67389ddfb148e2bbecf80daec3dafa8c6210d into faadd19b4018a53bda70f8eb5eb4...
|
Committer | Sebin Song |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
10
|
Skipped |
0
|
Passing |
112
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @SebinSong!
Can you please check all of the other places where this new flag is needed and add it?
For example, it's clearly needed here too:
@taoeffect I believe this issue has been fixed by below rule in this previous commit.
Once it's ensured you are testing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and it seems to work! Nice job!
closes #2520
[ Fix screenshot ]
This regression was introduced by the fix for #2249 which is something we must keep too. So as a fix, I created a boolean prop named
noEllipsis
that allows to opt out of this fix.