-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two bug-fixes for forced-color mode #2443
Two bug-fixes for forced-color mode #2443
Conversation
group-income Run #3493
Run Properties:
|
Project |
group-income
|
Branch Review |
sebin/task/#2385-image-viewer-in-forced-color-mode
|
Run status |
Passed #3493
|
Run duration | 08m 50s |
Commit |
88915fd1ff ℹ️: Merge 013f37796f5caceabebd8983a0050bf43f70ed4a into 5f68446576179fd93a5428ebfba3...
|
Committer | Sebin Song |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
10
|
Skipped |
0
|
Passing |
111
|
View all changes introduced in this branch ↗︎ |
This looks good, but I have an issue with this part:
That's not entirely accurate. See https://developer.mozilla.org/en-US/docs/Web/CSS/@media/forced-colors. In particular (emphasis mine):
So, instead of using |
@corrideat Those articles are informative actually. Updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @SebinSong!
closes #2385
closes #2440
[Fix 1]
[Fix 2]