#2425 - Improve navigation behaviour #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Nov 25, 2024
Comment on lines
-190
to
-195
| enableTimeTravel (evt) { | ||
| if (evt.shiftKey && process.env.NODE_ENV !== 'production') { | ||
| console.debug('enable time travel!') | ||
| this.ephemeral.timeTravelComponentName = 'TimeTravel' | ||
| } | ||
| }, |
There was a problem hiding this comment.
I noticed this logic related to time-travel is no longer used anywhere in the app. So just removed it.
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2425-improve-navigation-behaviour
|
| Run status |
|
| Run duration | 08m 55s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
corrideat
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2425
I noticed this issue happens in both Mobile/Desktop. I believe it makes sense to fold the menu regardless whether it navigates to a different page or the current page. So made that change as the fix. But please let me know if we don't want this.