Fix the broken DM notification #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Oct 22, 2024
Comment on lines
45
to
47
| isDMOrMention: isMentionedMe || getters.chatRoomAttributes.type === CHATROOM_TYPES.DIRECT_MESSAGE, | ||
| isDMOrMention: isMentionedMe || targetChatroomState.attributes.type === CHATROOM_TYPES.DIRECT_MESSAGE, |
There was a problem hiding this comment.
This was the cause of the issue.
getters.chatRoomAttributes getter here is for a currently active chatroom which means the DM notification only works when the receivers of the DM have the chatroom open in their browsers and this is what I observed too.
Made a fix here where it checks if the target chatroom is DM or not, regardless of whether the chatroom is active or not.
SebinSong
changed the title
SebinSong
changed the title
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2386-direct-message-notification-broken
|
| Run status |
|
| Run duration | 09m 09s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
|
@taoeffect The PR is ready for review. I can work on updating(or creating) a test item to check for this bug separately from this PR later. |
taoeffect
deleted the
sebin/task/#2386-direct-message-notification-broken
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve solution 1. of #2386
I can see the notification works properly now.