Remember whether the welcome screen was seen #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||
| Project |
group-income
|
| Run status |
|
| Run duration | 09m 38s |
| Commit |
|
| Committer | Ricardo Iván Vieitez Parra |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
corrideat
commented
Oct 12, 2024
| @@ -52,6 +54,14 @@ export default ({ | |||
| toDashboard () { | |||
| if (this.isButtonClicked) return | |||
| this.isButtonClicked = true | |||
| const groupContractID = this.currentGroupId | |||
There was a problem hiding this comment.
I'm wondering whether this should be here, or if instead it should be done on the /dashboard page on onMounted. Maybe it doesn't matter.
There was a problem hiding this comment.
Pros of doing it here: it's only done once (for users). Pros of doing it in the /dashboard page: we don't need to change the commands.js in the tests. Cons of doing it in the /dashboard page: need to do this check every time.
corrideat
force-pushed
the
welcome-page-vuex
branch
from
2ce1c8c to
83a69ce
Compare
taoeffect
requested changes
Oct 14, 2024
taoeffect
reviewed
Oct 14, 2024
taoeffect
reviewed
Oct 14, 2024
taoeffect
reviewed
Oct 15, 2024
taoeffect
reviewed
Oct 15, 2024
taoeffect
requested changes
Oct 15, 2024
corrideat
force-pushed
the
welcome-page-vuex
branch
from
b1549d9 to
b828d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.