#2002 allow DM to yourself #2343
Conversation
…low-dm-to-yourself
…low-dm-to-yourself
…low-dm-to-yourself
| @@ -117,9 +115,6 @@ export default ({ | |||
| watch: { | |||
| value () { | |||
| this.$emit('change', this.value) | |||
| }, | |||
| usernames () { | |||
| this.clear() | |||
There was a problem hiding this comment.
Apparently usernames here was meant to be removed in this previous commit but went unnoticed, causing a run-time error. So removed it here.
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2002-allow-dm-to-yourself
|
| Run status |
|
| Run duration | 09m 21s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
|
@taoeffect |
There was a problem hiding this comment.
Nice work @SebinSong, preliminary / partial review and one question:
| const partnerIDs = params.data.memberIDs | ||
| .filter(memberID => memberID !== rootGetters.ourIdentityContractId) | ||
| .map(memberID => rootGetters.ourContactProfilesById[memberID].contractID) |
There was a problem hiding this comment.
Why is this change being made? I don't quite understand the reason for filtering out our own contract even if it's intentionally specified.
There was a problem hiding this comment.
partnerIDs here is used to call sbp(gi.actions/chatroom/join) further down the logic [2], which is called by default for the DM creator [1].
await sbp('gi.actions/chatroom/join', { ... }) [1]
for (const partnerID of partnerIDs) {
await sbp('gi.actions/chatroom/join', { ... }) [2]
}Now that we expose the current user in this 'create new DM' modal list, there is cases where the members contain the current user too. This case needed to be taken account here.
|
@taoeffect Fixed the typo that caused that greyed-out photo issue. it does show now. 
|
closes #2002