Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cycling between multiple images in the image viewer #2391

Closed
SebinSong opened this issue Oct 22, 2024 · 0 comments · Fixed by #2419
Closed

Implement cycling between multiple images in the image viewer #2391

SebinSong opened this issue Oct 22, 2024 · 0 comments · Fixed by #2419
Assignees
@SebinSong
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX

Comments

@SebinSong
Copy link
Collaborator

Problem

As proposed in this comment of PR #2367 , make it possible to cycle between photos using the arrow keys on desktop if the message contains multiple photo attachments, similarly to what Slack does for the same case (below).

image

Solution

Implement it.
@SebinSong SebinSong added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend Note:UI/UX labels Oct 22, 2024
@SebinSong SebinSong self-assigned this Oct 22, 2024
SebinSong added a commit that referenced this issue Nov 4, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2391-mu…
b12cdd2 
…ltiple-images-in-the-viewer
@SebinSong SebinSong mentioned this issue Nov 11, 2024
Merged
SebinSong added a commit that referenced this issue Nov 27, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2391-mu…
8717b1d 
…ltiple-images-in-the-viewer
taoeffect pushed a commit that referenced this issue Nov 27, 2024
@SebinSong
#2391 - Multiple images in the viewer (#2419)
4464fea 
* extract all imagesgrunt dev

* send multiple image data to ImageViewerModal.vue

* render multiple images back to back in a container

* add prev/next btn to the modal

* implement keydown event for iamge navigation

* add loader animation to PreviewImageArea.vue

* add isTouch / fix isLoaded / update nav buttons

* fix the mobile issue

* fix the bug where the image abruptly changes the dimension

* revert the SW err handler

* update for Greg feedbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2391 - Multiple images in the viewer okTurtles/group-income
1 participant
@SebinSong