Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing messages on mobile looks wrong #2337

Closed
taoeffect opened this issue Sep 9, 2024 · 0 comments · Fixed by #2355
Closed

Editing messages on mobile looks wrong #2337

taoeffect opened this issue Sep 9, 2024 · 0 comments · Fixed by #2355
Assignees
@SebinSong
Labels
App:Frontend Kind:Bug Note:UI/UX Priority:High

Comments

@taoeffect
Copy link
Member

Problem

The edit field doesn't take up the space that it should. It looks really messed up:

a

Solution

Fix!
@SebinSong SebinSong mentioned this issue Sep 17, 2024
Merged
SebinSong added a commit that referenced this issue Sep 18, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2337-ed…
4eebb4f 
…it-message-ui-bug
taoeffect pushed a commit that referenced this issue Sep 20, 2024
@SebinSong
#2337 - Fix the overly tall chatroom height when a message is in edit…
c5c4e3c 
… mode (#2355)

* fix the overly tall textarea element in edit mode

* same max-height constraint for .c-send-mask

* DRY the max-height specification

* remove unecessary fix

* complete fix

* remove unecessary overflow:hidden

* increase the edit mode max-height

* remove unecessary side-paddings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Bug Note:UI/UX Priority:High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2337 - Fix the overly tall chatroom height when a message is in edit mode okTurtles/group-income
2 participants
@taoeffect @SebinSong