Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove originatingContractHeight from GIMessage head #2329

Closed
taoeffect opened this issue Sep 5, 2024 · 0 comments · Fixed by #2350
Closed

Remove originatingContractHeight from GIMessage head #2329

taoeffect opened this issue Sep 5, 2024 · 0 comments · Fixed by #2350
Assignees
@corrideat
Labels
App:Frontend Kind:Bug Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Advanced

Comments

@taoeffect
Copy link
Member

Problem

The value originatingContractHeight is in the head but it's not used from there, but instead is included as part of the encrypted payload, see discussion:

okTurtles/shelterprotocol.net#5

Solution

Remove originatingContractHeight from the head.
@taoeffect taoeffect added Kind:Bug Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend Level:Advanced Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. labels Sep 5, 2024
@taoeffect taoeffect mentioned this issue Sep 5, 2024
Closed
corrideat added a commit that referenced this issue Sep 15, 2024
@corrideat
Fix #2329. Remove unused GIMessage attributes.
0637904
@corrideat corrideat mentioned this issue Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corrideat corrideat

Labels
App:Frontend Kind:Bug Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Advanced
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2329. Remove unused GIMessage attributes. okTurtles/group-income
2 participants
@taoeffect @corrideat