Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamodb: fix potential panic in tableIsAlive method #580

Merged
merged 2 commits into from
Jun 1, 2018
Merged

dynamodb: fix potential panic in tableIsAlive method #580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21df0dc
dynamodb: fix potential panic in tableIsAlive method
adamstruck Jun 1, 2018
f9ef218
dynamodb: check err type in tableIsAlive method
adamstruck Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion database/dynamodb/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,17 @@ func (db *DynamoDB) tableIsAlive(ctx context.Context, name string) error {
case <-ctx.Done():
return ctx.Err()
case <-ticker:
r, _ := db.client.DescribeTable(&dynamodb.DescribeTableInput{
r, err := db.client.DescribeTable(&dynamodb.DescribeTableInput{
TableName: aws.String(name),
})
if err != nil {
if aerr, ok := err.(awserr.Error); ok {
if aerr.Code() == dynamodb.ErrCodeResourceNotFoundException {
continue
}
}
return err
}
if *r.Table.TableStatus == "ACTIVE" {
return nil
}
Expand Down