Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdash: optimize task list #576

Merged
merged 4 commits into from
May 31, 2018

Conversation

buchanae
Copy link
Contributor

closes #547

@buchanae buchanae changed the title webdash: ignore init calls from $watch webdash: optimize task list May 30, 2018
@buchanae
Copy link
Contributor Author

Also, closes #384 ...maybe

I added code to cache tasks in the browser, use the minimal view where possible, and stop the refresh loop when the page/tab is in the background.

It's still not ideal, but it's a substantial improvement. Previously, our task list was requesting about 500-800MB every two seconds, even when you weren't looking. Now, it's about 500 bytes when nothing has changed and nothing is running.

The page load is still slow on the first load (although faster than before). This might be improved in a number of ways: partial list rendering, server-side rendering, etc.

Our task views are kinda clunky. The basic view can still be pretty heavy, and the list doesn't need most of that weight (~500-700KB). We could improve this substantially by having server-side support for requesting specific fields, and/or being able to subscribe to an event stream.

@adamstruck
Copy link
Contributor

This looks like a great improvement. Could you apply the stoping of the background refresh loop while the page is in the background behavior to the task, node list and node pages as well?

@buchanae
Copy link
Contributor Author

Could you apply the stoping of the background refresh loop while the page is in the background behavior to the task, node list and node pages as well?

Done

@adamstruck adamstruck merged commit 8dff401 into ohsu-comp-bio:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web/dashboard: initial page load requests task list 3 times
2 participants