storage: bug fixes #461
Merged
storage: bug fixes #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamstruck
commented
Jan 26, 2018
•
adamstruck
commented
- fixed url parsing panic; closes storage/swift: panic #459
- fixed directory download bug that prevented recursive downloads of subdirectories
- better error reporting for SupportsGet/SupportsPut calls
adamstruck
force-pushed
the
storage-panic
branch
2 times, most recently
from
70d38eb
to
53a503a
Compare
buchanae
reviewed
Jan 29, 2018
storage/local.go
Outdated
| @@ -14,6 +14,7 @@ import ( | |||
|
|
|||
| // LocalBackend provides access to a local-disk storage system. | |||
| type LocalBackend struct { | |||
| Name string | |||
There was a problem hiding this comment.
Are these accidentally left over? Same for HTTP
|
Just the one question, otherwise looks good |
adamstruck
force-pushed
the
storage-panic
branch
2 times, most recently
from
b091c12
to
99b4a28
Compare
… download bug; better error reporting for SupportsGet/SupportsPut calls
adamstruck
force-pushed
the
storage-panic
branch
from
99b4a28
to
6b03c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.